make.py - Issue 332833002: Enable compiling with automatically-downloaded VS toolchain on Windows bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: make.py

Issue 332833002: Enable compiling with automatically-downloaded VS toolchain on Windows bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Upload from Linux Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: make.py

diff --git a/make.py b/make.py

index fc959a05ced5963461d85d001e4f83bd73588787..cb6c2a47faf4982dc763ff27504c1ab83b8f87e0 100644

--- a/make.py

+++ b/make.py

@@ -92,8 +92,9 @@ def MakeWindows(targets):

parameters:

targets: build targets as a list of strings

"""

- # TODO(epoger): I'm not sure if this is needed for ninja builds.

- CheckWindowsEnvironment()

+ if os.environ.get('CHROME_HEADLESS', '0') != '1':

+ # TODO(epoger): I'm not sure if this is needed for ninja builds.

+ CheckWindowsEnvironment()

# Run gyp_skia to prepare Visual Studio projects.

cd(SCRIPT_DIR)

« no previous file with comments | « make.bat ('k') | no next file » | no next file with comments »