Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332773002: Clean up SVGNames usage in core/rendering (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up SVGNames usage in core/rendering Clean up SVGNames usage in core/rendering, sometimes the header is included but it is not used. In some other spots, prefer "using namespace SVG". BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176049

Patch Set 1 #

Patch Set 2 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -72 lines) Patch
M Source/core/rendering/HitTestLocation.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTSpan.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGViewportContainer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 1 5 chunks +43 lines, -41 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL, simple cleanup.
6 years, 6 months ago (2014-06-12 16:39:23 UTC) #1
pdr.
On 2014/06/12 16:39:23, rwlbuis wrote: > PTAL, simple cleanup. LGTM
6 years, 6 months ago (2014-06-12 17:28:28 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-12 17:28:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/332773002/20001
6 years, 6 months ago (2014-06-12 17:28:46 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:32:53 UTC) #5
Message was sent while issue was closed. 
Change committed as 176049

Powered by Google App Engine
This is Rietveld 408576698