Issue 332653002: Mojo: Fix the C++ bindings generator for methods taking imported interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332653002: Mojo: Fix the C++ bindings generator for methods taking imported interfaces. (Closed)

Created:
6 years, 6 months ago by Sam McNally

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Fix the C++ bindings generator for methods taking imported interfaces. Previously, the namespace was omitted for interface and interface request arguments imported from another module. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276598

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -6 lines)			Patch
M	mojo/public/cpp/bindings/tests/handle_passing_unittest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	mojo/public/interfaces/bindings/tests/sample_factory.mojom	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	mojo/public/interfaces/bindings/tests/sample_import.mojom	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/mojom_cpp_generator.py	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/332653002/20001

6 years, 6 months ago (2014-06-12 04:58:34 UTC) #4

Message was sent while issue was closed.

Change committed as 276598

Expand Messages | Collapse Messages