mojo/public/interfaces/bindings/tests/sample_factory.mojom - Issue 332653002: Mojo: Fix the C++ bindings generator for methods taking imported interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/sample_factory.mojom

Issue 332653002: Mojo: Fix the C++ bindings generator for methods taking imported interfaces. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/handle_passing_unittest.cc ('k') | mojo/public/interfaces/bindings/tests/sample_import.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/sample_factory.mojom

diff --git a/mojo/public/interfaces/bindings/tests/sample_factory.mojom b/mojo/public/interfaces/bindings/tests/sample_factory.mojom

index daaed1e0a42767ae12d890a3c991b321b2f65130..f33864f2759dd369b8ad4548bad5f70137c5a6c5 100644

--- a/mojo/public/interfaces/bindings/tests/sample_factory.mojom

+++ b/mojo/public/interfaces/bindings/tests/sample_factory.mojom

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+import "sample_import.mojom"

[JavaPackage="org.chromium.mojo.bindings.test.sample"]

module sample {

@@ -29,6 +31,10 @@ interface Factory {

DoStuff(Request request, handle<message_pipe> pipe);

DoStuff2(handle<data_pipe_consumer> pipe);

CreateObject(Object& obj);

+ RequestImportedInterface(

+ imported.ImportedInterface& obj) => (imported.ImportedInterface& obj);

+ TakeImportedInterface(

+ imported.ImportedInterface obj) => (imported.ImportedInterface obj);

};

interface FactoryClient {