Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 3325025: Merge 67261 - Make middle clicks not fire DOM onclick events.... (Closed)

Created:
10 years, 3 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 67261 - Make middle clicks not fire DOM onclick events. https://bugs.webkit.org/show_bug.cgi?id=22382 Reviewed by Darin Adler. WebCore: * html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the computation of what constitutes a link click, since they're no longer implicitly included. (WebCore::isLinkClick): * html/HTMLInputElement.cpp: Removed unneeded checks that click events are coming from the left mouse button, since they all are now. (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler): * page/EventHandler.cpp: Changed logic to send a click event only for the left button. (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): LayoutTests: * fast/events/mouse-click-events-expected.txt: * fast/events/script-tests/mouse-click-events.js: TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/mouse-click-events-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/script-tests/mouse-click-events.js View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +22 lines, -1 line 0 comments Download
M WebCore/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/html/HTMLInputElement.cpp View 3 chunks +4 lines, -11 lines 0 comments Download
M WebCore/page/EventHandler.cpp View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
10 years, 3 months ago (2010-09-11 01:26:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698