WebCore/html/HTMLAnchorElement.cpp - Issue 3325025: Merge 67261 - Make middle clicks not fire DOM onclick events....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: WebCore/html/HTMLAnchorElement.cpp

Issue 3325025: Merge 67261 - Make middle clicks not fire DOM onclick events.... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: WebCore/html/HTMLAnchorElement.cpp

===================================================================

--- WebCore/html/HTMLAnchorElement.cpp (revision 67262)

+++ WebCore/html/HTMLAnchorElement.cpp (working copy)

@@ -514,7 +514,7 @@

bool isLinkClick(Event* event)

{

- return event->type() == eventNames().clickEvent && (!event->isMouseEvent() || static_cast<MouseEvent*>(event)->button() != RightButton);

+ return event->type() == eventNames().clickEvent || (event->type() == eventNames().mouseupEvent && isMiddleMouseButtonEvent(event));

}

void handleLinkClick(Event* event, Document* document, const String& url, const String& target, bool hideReferrer)

« no previous file with comments | « WebCore/ChangeLog ('k') | WebCore/html/HTMLInputElement.cpp » ('j') | no next file with comments »