Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: public/platform/WebLockOrientationCallback.h

Issue 332493003: Add a WebLockOrientationError independant from WebLockOrientationCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@platform_cleanup
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebLockOrientationCallback.h
diff --git a/public/platform/WebLockOrientationCallback.h b/public/platform/WebLockOrientationCallback.h
index 46642ab1f65dacfccebeffa36257f59b790bcba6..fcfbc75780fb020a66eb2b6f028a659cafd80a91 100644
--- a/public/platform/WebLockOrientationCallback.h
+++ b/public/platform/WebLockOrientationCallback.h
@@ -5,6 +5,7 @@
#ifndef WebLockOrientationCallback_h
#define WebLockOrientationCallback_h
+#include "public/platform/WebLockOrientationError.h"
#include "public/platform/WebScreenOrientationType.h"
namespace blink {
@@ -25,7 +26,11 @@ public:
virtual ~WebLockOrientationCallback() { }
virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
- virtual void onError(ErrorType) = 0;
+
+ // FIXME: those methods are defined and not virtual pure to not break the
+ // embedder during the transition period.
+ virtual void onError(ErrorType) { }
+ virtual void onError(WebLockOrientationError) { }
};
} // namespace blink
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | public/platform/WebLockOrientationError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698