Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: public/platform/WebLockOrientationCallback.h

Issue 332493003: Add a WebLockOrientationError independant from WebLockOrientationCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@platform_cleanup
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLockOrientationCallback_h 5 #ifndef WebLockOrientationCallback_h
6 #define WebLockOrientationCallback_h 6 #define WebLockOrientationCallback_h
7 7
8 #include "public/platform/WebLockOrientationError.h"
8 #include "public/platform/WebScreenOrientationType.h" 9 #include "public/platform/WebScreenOrientationType.h"
9 10
10 namespace blink { 11 namespace blink {
11 12
12 // WebScreenOrientationType is an interface to be used by the embedder in order 13 // WebScreenOrientationType is an interface to be used by the embedder in order
13 // to inform Blink when a screen lock operation has succeeded or failed. 14 // to inform Blink when a screen lock operation has succeeded or failed.
14 // A success notification comes with the new orientation angle and orientation 15 // A success notification comes with the new orientation angle and orientation
15 // type and a failure notification comes with an information about the type of 16 // type and a failure notification comes with an information about the type of
16 // failure. 17 // failure.
17 class WebLockOrientationCallback { 18 class WebLockOrientationCallback {
18 public: 19 public:
19 enum ErrorType { 20 enum ErrorType {
20 ErrorTypeNotAvailable, // If locking isn't available on the platform. 21 ErrorTypeNotAvailable, // If locking isn't available on the platform.
21 ErrorTypeFullScreenRequired, // If fullscreen is required to lock. 22 ErrorTypeFullScreenRequired, // If fullscreen is required to lock.
22 ErrorTypeCanceled, // If another lock/unlock got called before that one ended. 23 ErrorTypeCanceled, // If another lock/unlock got called before that one ended.
23 }; 24 };
24 25
25 virtual ~WebLockOrientationCallback() { } 26 virtual ~WebLockOrientationCallback() { }
26 27
27 virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0; 28 virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
28 virtual void onError(ErrorType) = 0; 29
30 // FIXME: those methods are defined and not virtual pure to not break the
31 // embedder during the transition period.
32 virtual void onError(ErrorType) { }
33 virtual void onError(WebLockOrientationError) { }
29 }; 34 };
30 35
31 } // namespace blink 36 } // namespace blink
32 37
33 #endif // WebLockOrientationCallback_h 38 #endif // WebLockOrientationCallback_h
OLDNEW
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | public/platform/WebLockOrientationError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698