Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 332493003: Add a WebLockOrientationError independant from WebLockOrientationCallback. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
Reviewers:
tkent, abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@platform_cleanup
Project:
blink
Visibility:
Public.

Description

Add a WebLockOrientationError independant from WebLockOrientationCallback. So we don't need to include WebLockOrientationCallback in places where we should only include enums. BUG=162827 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M Source/modules/screen_orientation/LockOrientationCallback.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/LockOrientationCallback.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M public/platform/WebLockOrientationCallback.h View 2 chunks +6 lines, -1 line 0 comments Download
A public/platform/WebLockOrientationError.h View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
mlamouri (slow - plz ping)
Kent-san, could you have a look at this please? It was required by reviewers so ...
6 years, 6 months ago (2014-06-18 13:07:17 UTC) #1
mlamouri (slow - plz ping)
On 2014/06/18 13:07:17, Mounir Lamouri wrote: > Kent-san, could you have a look at this ...
6 years, 6 months ago (2014-06-18 13:23:28 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-18 23:36:10 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-19 09:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/332493003/1
6 years, 6 months ago (2014-06-19 09:25:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 10:40:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19155)
6 years, 6 months ago (2014-06-19 10:40:39 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-19 11:19:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/332493003/1
6 years, 6 months ago (2014-06-19 11:19:38 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 12:55:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19181)
6 years, 6 months ago (2014-06-19 12:55:32 UTC) #11
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-19 13:03:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/332493003/1
6 years, 6 months ago (2014-06-19 13:03:20 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 13:04:04 UTC) #14
Message was sent while issue was closed.
Change committed as 176510

Powered by Google App Engine
This is Rietveld 408576698