Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 332333002: Version 3.26.31.6 (merged r21509, r21858, r21525) (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Version 3.26.31.6 (merged r21509, r21858, r21525) Avoid HeapObject check in HStoreNamedField. Add unit test for regression in GVN caused by field type tracking. MIPS: Avoid HeapObject check in HStoreNamedField. BUG=v8:3347 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -147 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +7 lines, -18 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +6 lines, -24 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -10 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +7 lines, -18 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +6 lines, -23 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-gvn-ftt.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 6 months ago (2014-06-17 04:39:55 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 6 months ago (2014-06-17 04:40:28 UTC) #2
Benedikt Meurer
6 years, 6 months ago (2014-06-17 04:41:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21863 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698