Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 332283002: Mac: Fix hidden find bar preventing context menu from appearing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
index b328234f01a6e542e593f142e09bb8283556e24c..6433c73d3a30a45db18c6d55fdc46697d7dfee9d 100644
--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
@@ -113,6 +113,7 @@ const float kRightEdgeOffset = 25;
[findBarView_ setFrame:[self hiddenFindBarFrame]];
defaultWidth_ = NSWidth([findBarView_ frame]);
+ [[self view] setHidden:YES];
[self prepopulateText:[[FindPasteboard sharedInstance] findText]];
}
@@ -449,7 +450,7 @@ const float kRightEdgeOffset = 25;
// If the find bar is not visible, make it actually hidden, so it'll no longer
// respond to key events.
- [findBarView_ setHidden:![self isFindBarVisible]];
+ [[self view] setHidden:![self isFindBarVisible]];
[[self browserWindowController] onFindBarVisibilityChanged];
}
@@ -505,7 +506,7 @@ const float kRightEdgeOffset = 25;
if (!animate) {
[findBarView_ setFrame:endFrame];
- [findBarView_ setHidden:![self isFindBarVisible]];
+ [[self view] setHidden:![self isFindBarVisible]];
[[self browserWindowController] onFindBarVisibilityChanged];
showHideAnimation_.reset(nil);
return;
@@ -513,7 +514,7 @@ const float kRightEdgeOffset = 25;
// If animating, ensure that the find bar is not hidden. Hidden status will be
// updated at the end of the animation.
- [findBarView_ setHidden:NO];
+ [[self view] setHidden:NO];
//[[self browserWindowController] onFindBarVisibilityChanged];
// Reset the frame to what was saved above.
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698