chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm - Issue 332283002: Mac: Fix hidden find bar preventing context menu from appearing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm

Issue 332283002: Mac: Fix hidden find bar preventing context menu from appearing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm

index 1c31a43c46f0882dc2aae2b28d4ca03553e25174..28124c4344bfb9d90f6e9f8c046e42487704277f 100644

--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm

@@ -63,14 +63,17 @@ TEST_F(FindBarCocoaControllerTest, ShowAndHide) {

ASSERT_GT([findBarView frame].origin.y, 0);

ASSERT_FALSE([controller_ isFindBarVisible]);

+ ASSERT_TRUE([[controller_ view] isHidden]);

[controller_ showFindBar:NO];

EXPECT_EQ([findBarView frame].origin.y, 0);

EXPECT_TRUE([controller_ isFindBarVisible]);

+ ASSERT_FALSE([[controller_ view] isHidden]);

[controller_ hideFindBar:NO];

EXPECT_GT([findBarView frame].origin.y, 0);

EXPECT_FALSE([controller_ isFindBarVisible]);

+ ASSERT_TRUE([[controller_ view] isHidden]);

}

TEST_F(FindBarCocoaControllerTest, SetFindText) {

« no previous file with comments | « chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm ('k') | no next file » | no next file with comments »