Issue 332283002: Mac: Fix hidden find bar preventing context menu from appearing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332283002: Mac: Fix hidden find bar preventing context menu from appearing. (Closed)

Created:
6 years, 6 months ago by Andre

Modified:
6 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mac: Fix hidden find bar preventing context menu from appearing. When the find bar is hidden, there is still an invisible view (its superview) in its place that was consuming the right-click event. Fixed this by hiding the find bar superview instead. Also make sure that the initial state is set to hidden. TEST=Invoke find bar then close it, right-click where the find bar was, context menu should appear. BUG=381207 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277883

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm	View		4 chunks	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/332283002/1

6 years, 6 months ago (2014-06-17 18:42:23 UTC) #4

Message was sent while issue was closed.

Change committed as 277883

Expand Messages | Collapse Messages