Chromium Code Reviews| Index: components/autofill/core/browser/autofill_profile_unittest.cc |
| diff --git a/components/autofill/core/browser/autofill_profile_unittest.cc b/components/autofill/core/browser/autofill_profile_unittest.cc |
| index de550bd827bd869c9966a9a650fba85111e746db..01046a461eb277cf4ff9123137fe9931be1b0e21 100644 |
| --- a/components/autofill/core/browser/autofill_profile_unittest.cc |
| +++ b/components/autofill/core/browser/autofill_profile_unittest.cc |
| @@ -654,6 +654,18 @@ TEST(AutofillProfileTest, Compare) { |
| NULL, NULL, NULL, NULL, NULL, NULL, NULL, "408.555.4321"); |
| EXPECT_GT(0, a.Compare(b)); |
| EXPECT_LT(0, b.Compare(a)); |
| + |
| + // Addresses are compared in full. Regression test for http://crbug.com/375545 |
| + test::SetProfileInfo(&a, "John", NULL, NULL, NULL, |
| + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); |
|
Dan Beam
2014/06/16 19:30:20
what kind of pointer do you want? we have NULL and
|
| + a.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS, |
| + ASCIIToUTF16("line one\nline two")); |
| + test::SetProfileInfo(&b, "John", NULL, NULL, NULL, |
| + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); |
| + b.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS, |
| + ASCIIToUTF16("line one\nline two\nline three")); |
| + EXPECT_GT(0, a.Compare(b)); |
|
Dan Beam
2014/06/16 19:30:20
nit: EXPECT_NE(0,
Evan Stade
2014/06/16 19:33:09
I kind of agree, but I'm matching the format of th
|
| + EXPECT_LT(0, b.Compare(a)); |
| } |
| TEST(AutofillProfileTest, MultiValueNames) { |