Fix profile comparison re: address lines.

components/autofill/core/browser/autofill_profile_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
@@ skipping 636 matching lines @@
   EXPECT_LT(0, b.Compare(a));
 
   // Phone numbers are compared by the full number, including the area code.
   // This is a regression test for http://crbug.com/163024
   test::SetProfileInfo(&a, NULL, NULL, NULL, NULL,
       NULL, NULL, NULL, NULL, NULL, NULL, NULL, "650.555.4321");
   test::SetProfileInfo(&b, NULL, NULL, NULL, NULL,
       NULL, NULL, NULL, NULL, NULL, NULL, NULL, "408.555.4321");
   EXPECT_GT(0, a.Compare(b));
   EXPECT_LT(0, b.Compare(a));
+
+  // Addresses are compared in full. Regression test for http://crbug.com/375545
+  test::SetProfileInfo(&a, "John", NULL, NULL, NULL,
+      NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);

[Dan Beam, 2014/06/16 19:30:20]

what kind of pointer do you want? we have NULL and NULL... [1]

[1] https://www.youtube.com/watch?v=anwy2MPT5RE

+  a.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS,
+               ASCIIToUTF16("line one\nline two"));
+  test::SetProfileInfo(&b, "John", NULL, NULL, NULL,
+      NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
+  b.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS,
+               ASCIIToUTF16("line one\nline two\nline three"));
+  EXPECT_GT(0, a.Compare(b));

[Dan Beam, 2014/06/16 19:30:20]

nit: EXPECT_NE(0, 

[Evan Stade, 2014/06/16 19:33:09]

I kind of agree, but I'm matching the format of the other tests.

+  EXPECT_LT(0, b.Compare(a));
 }
 
 TEST(AutofillProfileTest, MultiValueNames) {
   AutofillProfile p(base::GenerateGUID(), "https://www.example.com/");
   const base::string16 kJohnDoe(ASCIIToUTF16("John Doe"));
   const base::string16 kJohnPDoe(ASCIIToUTF16("John P. Doe"));
   std::vector<base::string16> set_values;
   set_values.push_back(kJohnDoe);
   set_values.push_back(kJohnPDoe);
   p.SetRawMultiInfo(NAME_FULL, set_values);
@@ skipping 225 matching lines @@
                                ASCIIToUTF16("CA"),
                                "en-US");
   EXPECT_FALSE(profile.GetInfo(full_address, "en-US").empty());
   profile.SetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
                                base::string16(),
                                "en-US");
   EXPECT_TRUE(profile.GetInfo(full_address, "en-US").empty());
 }
 
 }  // namespace autofill