Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332213003: Move telemetry/core/timeline and timeline_data to telemetry/timeline. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move telemetry/core/timeline and timeline_data to telemetry/timeline. This package handles trace parsing and it should be a standalone package. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278020

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3238 lines) Patch
M content/test/gpu/gpu_tests/memory.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smooth_gesture_util_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/network.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/network_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/speedindex_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/timeline_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_network.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_network_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_timeline.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/core/backends/chrome/inspector_timeline_data.py View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/core/timeline/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/telemetry/core/timeline/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/async_slice.py View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/bounds.py View 1 chunk +0 lines, -114 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/bounds_unittest.py View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/counter.py View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/empty_timeline_data_importer.py View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/empty_timeline_data_importer_unittest.py View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/event.py View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/event_container.py View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/event_unittest.py View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/flow_event.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/importer.py View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/inspector_importer.py View 1 chunk +0 lines, -81 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/inspector_importer_unittest.py View 1 chunk +0 lines, -148 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/model.py View 1 chunk +0 lines, -247 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/model_unittest.py View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/process.py View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/recording_options.py View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/sample.py View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/slice.py View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/slice_unittest.py View 1 chunk +0 lines, -34 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/thread.py View 1 chunk +0 lines, -267 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/thread_unittest.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/trace_event_importer.py View 1 chunk +0 lines, -467 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py View 1 chunk +0 lines, -1189 lines 0 comments Download
D tools/telemetry/telemetry/core/timeline_data.py View 1 chunk +0 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/async_slice.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/bounds.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/bounds_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/counter.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/empty_timeline_data_importer.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/empty_timeline_data_importer_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/event.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/event_container.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/event_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/flow_event.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/importer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/inspector_importer.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/inspector_importer_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/inspector_timeline_data.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/model.py View 1 chunk +5 lines, -5 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/model_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/process.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/recording_options.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/sample.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/slice.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/slice_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/thread.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/thread_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/timeline/timeline_data.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/trace_event_importer.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py View 1 chunk +4 lines, -4 lines 0 comments Download
A + tools/telemetry/telemetry/timeline/tracing_timeline_data.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-16 18:48:20 UTC) #1
tonyg
lgtm assuming all the bots are happy
6 years, 6 months ago (2014-06-17 15:11:20 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-17 15:16:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/332213003/1
6 years, 6 months ago (2014-06-17 15:16:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 19:02:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/24903)
6 years, 6 months ago (2014-06-17 19:02:50 UTC) #6
nednguyen
+kbr for change to content/test/gpu/gpu_tests/memory.py
6 years, 6 months ago (2014-06-17 20:06:41 UTC) #7
Ken Russell (switch to Gerrit)
content/test/gpu LGTM
6 years, 6 months ago (2014-06-17 21:39:11 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-17 23:04:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/332213003/20001
6 years, 6 months ago (2014-06-17 23:06:51 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:39:28 UTC) #11
Message was sent while issue was closed. 
Change committed as 278020

Powered by Google App Engine
This is Rietveld 408576698