tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py - Issue 332213003: Move telemetry/core/timeline and timeline_data to telemetry/timeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py

Issue 332213003: Move telemetry/core/timeline and timeline_data to telemetry/timeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py b/tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py

index e37a1f80a385e8bec0a7d22ba0e78ae7940c0318..f406b12c1403169a175c9b550506c219cb5c6f00 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py

@@ -29,7 +29,7 @@ def _TimeRangesHasOverlap(iterable_time_ranges):

class TimelineBasedMetric(object):

def __init__(self):

- """Computes metrics from a telemetry.core.timeline Model and a range

+ """Computes metrics from a telemetry.timeline Model and a range

"""

super(TimelineBasedMetric, self).__init__()

@@ -41,7 +41,7 @@ class TimelineBasedMetric(object):

within the interaction_records' start and end time ranges.

Args:

- model: An instance of telemetry.core.timeline.model.TimelineModel.

+ model: An instance of telemetry.timeline.model.TimelineModel.

interaction_records: A list of instances of TimelineInteractionRecord. If

the override of this method doesn't support overlapped ranges, use

VerifyNonOverlappedRecords to check that no records are overlapped.