Issue 332173002: DevTools: Add test multi-target-breakpoint-manager.html

Issue 332173002: DevTools: Add test multi-target-breakpoint-manager.html (Closed)

Created:
6 years, 6 months ago by sergeyv

Modified:
6 years, 6 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Add test multi-target-breakpoint-manager.html BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176204

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address vsevik's comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -19 lines)			Patch
M	LayoutTests/inspector/sources/debugger/breakpoint-manager.html	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	LayoutTests/inspector/sources/debugger/breakpoint-manager.js	View		6 chunks	+24 lines, -5 lines	0 comments	Download
A	LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager-expected.txt	View	1	1 chunk	+74 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/Target.js	View		1 chunk	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html File LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html (right): https://chromiumcodereview.appspot.com/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html#newcode30 LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html:30: InspectorTest.addResult(" Second target intruded!"); added. https://chromiumcodereview.appspot.com/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html#newcode43 LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html:43: InspectorTest.addResult(" ...

6 years, 6 months ago (2014-06-16 11:12:35 UTC) #2

vsevik

> https://chromiumcodereview.appspot.com/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html#newcode80 > LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html:80: > Can we also test debuggerModel disabling? Please disregard this.

6 years, 6 months ago (2014-06-16 11:13:22 UTC) #3

sergeyv

https://codereview.chromium.org/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html File LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html (right): https://codereview.chromium.org/332173002/diff/1/LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html#newcode30 LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html:30: InspectorTest.addResult(" Second target intruded!"); On 2014/06/16 11:12:35, vsevik wrote: ...

6 years, 6 months ago (2014-06-16 11:21:45 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/332173002/20001

6 years, 6 months ago (2014-06-16 11:22:14 UTC) #6

Message was sent while issue was closed.

Change committed as 176204

Expand Messages | Collapse Messages