Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: Source/devtools/front_end/sdk/Target.js

Issue 332173002: DevTools: Add test multi-target-breakpoint-manager.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address vsevik's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/Target.js
diff --git a/Source/devtools/front_end/sdk/Target.js b/Source/devtools/front_end/sdk/Target.js
index 52b892ca54e6b606ad4a24676606f5cbc61c947d..1e354875d6daa93acc3acfc15f83fe63366aa56d 100644
--- a/Source/devtools/front_end/sdk/Target.js
+++ b/Source/devtools/front_end/sdk/Target.js
@@ -257,17 +257,35 @@ WebInspector.TargetManager.prototype = {
*/
function callbackWrapper(newTarget)
{
- this._targets.push(newTarget);
- var copy = this._observers;
- for (var i = 0; i < copy.length; ++i)
- copy[i].targetAdded(newTarget);
-
+ this.addTarget(newTarget);
if (callback)
callback(newTarget);
}
},
/**
+ * @param {!WebInspector.Target} newTarget
+ */
+ addTarget: function(newTarget)
+ {
+ this._targets.push(newTarget);
+ var copy = this._observers;
+ for (var i = 0; i < copy.length; ++i)
+ copy[i].targetAdded(newTarget);
+ },
+
+ /**
+ * @param {!WebInspector.Target} target
+ */
+ removeTarget: function(target)
+ {
+ this._targets.remove(target);
+ var copy = this._observers;
+ for (var i = 0; i < copy.length; ++i)
+ copy[i].targetRemoved(target);
+ },
+
+ /**
* @return {!Array.<!WebInspector.Target>}
*/
targets: function()
« no previous file with comments | « LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698