Green the garden-o-matic unittests.

Green the garden-o-matic unittests.

Also fixes a real bug where we reversed the order of the
type/release/debug columns for the list of failing builders,
but we didn't adjust cellByBuildType or the tests to account
for it. Instead, re-reverse the order. Tests pass, bug fixed.
I'm not sure when this bug got introduced, but its at least
from before the Blink fork, as are most of these other test
failures.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176161

[ojan, 2014-06-15 00:43:44]

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
File Tools/GardeningServer/scripts/checkout_unittests.js (right):

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
Tools/GardeningServer/scripts/checkout_unittests.js:142: ok(true);
checkout.rebaseline changed to all the processCallback unconditionally, so this
gets called now.

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
File Tools/GardeningServer/scripts/ui/failures.js (right):

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
Tools/GardeningServer/scripts/ui/failures.js:83: titles.insertCell().textContent
= 'debug';
This and the lines just below it are the only functional changes. This reverses
the order of these three columns.

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
File Tools/GardeningServer/scripts/ui/notifications_unittests.js (right):

https://codereview.chromium.org/332073002/diff/20001/Tools/GardeningServer/sc...
Tools/GardeningServer/scripts/ui/notifications_unittests.js:81:
test('FailingTestsSummary', 10, function() {
Not sure what was going on here, but I counted the number of asserts and there
are indeed only 10.

[abarth-chromium, 2014-06-15 03:41:02]

lgtm

[abarth-chromium, 2014-06-15 03:41:31]

We probably want to figure out a better testing strategy.  Having these golden
HTML snippets hasn't scaled well.

[ojan, 2014-06-15 03:57:51]

On 2014/06/15 at 03:41:31, abarth wrote:
> We probably want to figure out a better testing strategy.  Having these golden
HTML snippets hasn't scaled well.

It's not awesome, but I'm not sure it's that big of a deal. Most of these
failures are accumulated from before the Blink fork. If we are careful to always
run the tests when we make changes, I don't think it'll be that bad. It is a
pain though. There's no argument there. So I'm open to a better strategy.

[ojan, 2014-06-15 03:57:55]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-06-15 03:59:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/332073002/20001

[commit-bot: I haz the power, 2014-06-15 04:00:04]

Change committed as 176161