Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: Tools/GardeningServer/scripts/ui/failures.js

Issue 332073002: Green the garden-o-matic unittests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix temp change Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/scripts/ui/failures.js
diff --git a/Tools/GardeningServer/scripts/ui/failures.js b/Tools/GardeningServer/scripts/ui/failures.js
index 0703a381215d73771cf9c12cd083851265b82d19..fbdb5a64274c8c504eeac1daf5f25fb98b0383e3 100644
--- a/Tools/GardeningServer/scripts/ui/failures.js
+++ b/Tools/GardeningServer/scripts/ui/failures.js
@@ -57,7 +57,7 @@ ui.failures.Builder = base.extends('a', {
},
equals: function(configuration)
{
- return this._configuration && this._configuration.is64bit == configuration.is64bit && this._configuration.version == configuration.version;
+ return this._configuration && this._configuration.is64bit == configuration.is64bit && this._configuration.version == configuration.version;
}
});
@@ -78,9 +78,9 @@ ui.failures.FailureGrid = base.extends('table', {
{
this.className = 'failures';
var titles = this.createTHead().insertRow();
- titles.insertCell().textContent = 'debug';
- titles.insertCell().textContent = 'release';
titles.insertCell().textContent = 'type';
+ titles.insertCell().textContent = 'release';
+ titles.insertCell().textContent = 'debug';
ojan 2014/06/15 00:43:44 This and the lines just below it are the only func
this._body = this.appendChild(document.createElement('tbody'));
this._reset();
},
@@ -93,10 +93,10 @@ ui.failures.FailureGrid = base.extends('table', {
row = this._resultRows[result] = this._body.insertRow(0);
row.className = result;
- row.insertCell();
- row.insertCell();
var titleCell = row.insertCell();
titleCell.appendChild(document.createElement('span')).textContent = result;
+ row.insertCell();
+ row.insertCell();
return row;
},
update: function(resultsByBuilder)

Powered by Google App Engine
This is Rietveld 408576698