chrome/test/chromedriver/session.cc - Issue 331943003: [ChromeDriver] Added CommandListener interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session.cc

Issue 331943003: [ChromeDriver] Added CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CommandListener now abstract; Session struct simplified Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/session.cc

diff --git a/chrome/test/chromedriver/session.cc b/chrome/test/chromedriver/session.cc

index d46918e0d0f0d6d6b0529ad87f6edf8aab11012d..a986ad2b8edd0a21b5c869733417cace688783a1 100644

--- a/chrome/test/chromedriver/session.cc

+++ b/chrome/test/chromedriver/session.cc

@@ -82,6 +82,11 @@ void Session::SwitchToSubFrame(const std::string& frame_id,

frames.push_back(FrameInfo(parent_frame_id, frame_id, chromedriver_frame_id));

}

+void Session::AddListener(CommandListener* listener) {

+ CHECK(listener);

+ command_listeners.push_back(listener);

std::string Session::GetCurrentFrameId() const {

if (frames.empty())

return std::string();