[ChromeDriver] Added CommandListener interface

chrome/test/chromedriver/command_listener.h

Index: chrome/test/chromedriver/command_listener.h
diff --git a/chrome/test/chromedriver/command_listener.h b/chrome/test/chromedriver/command_listener.h
new file mode 100644
index 0000000000000000000000000000000000000000..36f77257f6e1799281d293e39695ba2f8fe22c46
--- /dev/null
+++ b/chrome/test/chromedriver/command_listener.h
@@ -0,0 +1,22 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_

[johnmoore, 2014/06/20 18:47:53]

I've realized that anything in chromedriver/chrome/ that includes
chromedriver/command_listener.h will fail the pre-submit dependency checks since
chromedriver/chrome/ is supposed to be independent of everything in
chromedriver/.

Question for Shuotao (all comments welcome): Should I move command_listener.h
into chromedriver/chrome/, or should I make an exception in the dependency
checks?

[stgao, 2014/06/20 22:36:49]

We'd better still separate chromedriver/chrome/ entirely from chromedriver/.

chromedriver/chrome/ is an abstraction of Chrome and it should know nothing
about webdriver.

But why do you want CommandListener to be aware of by chromedriver/chrome?
Is it because of PerformanceLogger?
If so, let's move PerformanceLogger out to /chromedriver.

+#define CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_
+
+#include <string>
+
+class Status;
+
+class CommandListener {
+ public:
+  virtual ~CommandListener() {}
+
+  // Called just before a WebDriver command is run, but only
+  // for commands that operate on an existing session. Will be called for
+  // WindowCommands, ElementCommands, SessionCommands, and AlertCommands.
+  virtual Status BeforeCommand(const std::string& command_name) = 0;
+};
+
+#endif  // CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_