chrome/test/chromedriver/command_listener.h - Issue 331943003: [ChromeDriver] Added CommandListener interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/command_listener.h

Issue 331943003: [ChromeDriver] Added CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CommandListener now abstract; Session struct simplified Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_
	johnmoore 2014/06/20 18:47:53 I've realized that anything in chromedriver/chrome I've realized that anything in chromedriver/chrome/ that includes chromedriver/command_listener.h will fail the pre-submit dependency checks since chromedriver/chrome/ is supposed to be independent of everything in chromedriver/. Question for Shuotao (all comments welcome): Should I move command_listener.h into chromedriver/chrome/, or should I make an exception in the dependency checks? stgao 2014/06/20 22:36:49 We'd better still separate chromedriver/chrome/ en Show quoted text On 2014/06/20 18:47:53, johnmoore wrote: > I've realized that anything in chromedriver/chrome/ that includes > chromedriver/command_listener.h will fail the pre-submit dependency checks since > chromedriver/chrome/ is supposed to be independent of everything in > chromedriver/. > > Question for Shuotao (all comments welcome): Should I move command_listener.h > into chromedriver/chrome/, or should I make an exception in the dependency > checks? We'd better still separate chromedriver/chrome/ entirely from chromedriver/. chromedriver/chrome/ is an abstraction of Chrome and it should know nothing about webdriver. But why do you want CommandListener to be aware of by chromedriver/chrome? Is it because of PerformanceLogger? If so, let's move PerformanceLogger out to /chromedriver.
	6 #define CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_

	7

	8 #include <string>

	9

	10 class Status;

	11

	12 class CommandListener {

	13 public:

	14 virtual ~CommandListener() {}

	15

	16 // Called just before a WebDriver command is run, but only

	17 // for commands that operate on an existing session. Will be called for

	18 // WindowCommands, ElementCommands, SessionCommands, and AlertCommands.

	19 virtual Status BeforeCommand(const std::string& command_name) = 0;

	20 };

	21

	22 #endif // CHROME_TEST_CHROMEDRIVER_COMMAND_LISTENER_H_

OLD	NEW

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/commands.cc » ('j') | no next file with comments »