Remove bogus assertions in HCompareObjectEqAndBranch.

Remove bogus assertions in HCompareObjectEqAndBranch.

R=jkummerow@chromium.org, danno@chromium.org
BUG=387636
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=21959

[Yang, 2014-06-23 12:27:01]

On 2014/06/23 12:11:51, Yang wrote:

The assertions were originally added in [0]. I suspect that they were supposed
to catch the false negative in [1]: comparing a non-smi int would result in
comparing two heap number constants. In the original implementation, we used
HValue::Equals for equality, which would return false for two distinct HConstant
values holding the same double value, but in two different heap number objects.

This has been fixed in [2] that addressed a different, but similar issue. The
assertions are obsolete since.

[0]
https://codereview.chromium.org/22876009/diff/88001/src/hydrogen-instructions.h
(4133 ff.)
[1]
https://codereview.chromium.org/22876009/diff/88001/src/hydrogen-instructions.cc
(2889 ff.)
[2] https://codereview.chromium.org/195063002/

[Jakob Kummerow, 2014-06-24 08:42:03]

I can't fathom what those ASSERTs might have been useful for. Either way they
don't seem to make much sense now, so... LGTM with nits.

https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
File test/mjsunit/regress/regress-crbug-387636.js (right):

https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
test/mjsunit/regress/regress-crbug-387636.js:1: // Copyright 2012 the V8 project
authors. All rights reserved.
nit: 2014

https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
test/mjsunit/regress/regress-crbug-387636.js:7: function f(x) {
nit: what do we need |x| for?

[Yang, 2014-06-24 08:48:54]

On 2014/06/24 08:42:03, Jakob wrote:
> I can't fathom what those ASSERTs might have been useful for. Either way they
> don't seem to make much sense now, so... LGTM with nits.
> 
>
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
> File test/mjsunit/regress/regress-crbug-387636.js (right):
> 
>
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
> test/mjsunit/regress/regress-crbug-387636.js:1: // Copyright 2012 the V8
project
> authors. All rights reserved.
> nit: 2014
> 
>
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/reg...
> test/mjsunit/regress/regress-crbug-387636.js:7: function f(x) {
> nit: what do we need |x| for?

You are right. The argument is not necessary for the repro.

[Yang, 2014-06-24 09:33:13]

Committed patchset #3 manually as r21959 (presubmit successful).