Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: src/hydrogen-instructions.h

Issue 331863015: Remove bogus assertions in HCompareObjectEqAndBranch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-387636.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 4365 matching lines...) Expand 10 before | Expand all | Expand 10 after
4376 } 4376 }
4377 4377
4378 DECLARE_CONCRETE_INSTRUCTION(CompareObjectEqAndBranch) 4378 DECLARE_CONCRETE_INSTRUCTION(CompareObjectEqAndBranch)
4379 4379
4380 private: 4380 private:
4381 HCompareObjectEqAndBranch(HValue* left, 4381 HCompareObjectEqAndBranch(HValue* left,
4382 HValue* right, 4382 HValue* right,
4383 HBasicBlock* true_target = NULL, 4383 HBasicBlock* true_target = NULL,
4384 HBasicBlock* false_target = NULL) 4384 HBasicBlock* false_target = NULL)
4385 : known_successor_index_(kNoKnownSuccessorIndex) { 4385 : known_successor_index_(kNoKnownSuccessorIndex) {
4386 ASSERT(!left->IsConstant() ||
4387 (!HConstant::cast(left)->HasInteger32Value() ||
4388 HConstant::cast(left)->HasSmiValue()));
4389 ASSERT(!right->IsConstant() ||
4390 (!HConstant::cast(right)->HasInteger32Value() ||
4391 HConstant::cast(right)->HasSmiValue()));
4392 SetOperandAt(0, left); 4386 SetOperandAt(0, left);
4393 SetOperandAt(1, right); 4387 SetOperandAt(1, right);
4394 SetSuccessorAt(0, true_target); 4388 SetSuccessorAt(0, true_target);
4395 SetSuccessorAt(1, false_target); 4389 SetSuccessorAt(1, false_target);
4396 } 4390 }
4397 4391
4398 int known_successor_index_; 4392 int known_successor_index_;
4399 }; 4393 };
4400 4394
4401 4395
(...skipping 3391 matching lines...) Expand 10 before | Expand all | Expand 10 after
7793 }; 7787 };
7794 7788
7795 7789
7796 7790
7797 #undef DECLARE_INSTRUCTION 7791 #undef DECLARE_INSTRUCTION
7798 #undef DECLARE_CONCRETE_INSTRUCTION 7792 #undef DECLARE_CONCRETE_INSTRUCTION
7799 7793
7800 } } // namespace v8::internal 7794 } } // namespace v8::internal
7801 7795
7802 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7796 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-387636.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698