Issue 331833003: Revert "Add "last" setter to List."

Issue 331833003: Revert "Add "last" setter to List." (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org, Kevin Millikin (Google), kevmoo

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Add "last" setter to List." After discussion, we decided not to change the List interface for something that is just a convenience. Also revert "Mark pkgbuild/pkg/collection as failing when using repository packages" R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37307

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -146 lines)			Patch
M	pkg/collection/lib/wrappers.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	pkg/collection/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/collection/test/wrapper_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/pkgbuild.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/third_party/html5lib/lib/dom.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/third_party/html5lib/lib/src/list_proxy.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/third_party/html5lib/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/array.dart	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	samples-dev/swarm/swarm_ui_lib/observable/observable.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_array.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/collection/list.dart	View	8 chunks	+11 lines, -16 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	sdk/lib/internal/list.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	tests/corelib/list_test.dart	View	3 chunks	+0 lines, -35 lines	0 comments	Download
M	third_party/pkg/js/lib/src/wrapping/js/array_to_list_adapter.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	tools/dom/src/ImmutableListMixin.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

6 years, 6 months ago (2014-06-13 09:40:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37307 (presubmit successful).

Expand Messages | Collapse Messages