Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 331783003: Correct comment in bindings template (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Correct comment in bindings template Comment-only change. An existing comment explains some code as saying "necessary for MSVC", but it's actually required by the C++ standard. This CL corrects the comment and explains. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176075

Patch Set 1 #

Patch Set 2 : Better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/bindings/templates/interface.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Just noticed a comment error/omission; it's a bit subtle, so I quoted the standard.
6 years, 6 months ago (2014-06-13 01:20:08 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-13 01:26:29 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 01:30:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/331783003/20001
6 years, 6 months ago (2014-06-13 01:31:50 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 02:34:14 UTC) #5
Message was sent while issue was closed.
Change committed as 176075

Powered by Google App Engine
This is Rietveld 408576698