Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 331783003: Correct comment in bindings template (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Better comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index f90e254bdc07551b936117e7185cf3ba2a24937e..d305d9d45bed46acf2f2d7afe6bd10b9aa6e92ec 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -893,7 +893,12 @@ static void configure{{v8_class}}Template(v8::Handle<v8::FunctionTemplate> funct
{% set runtime_enabled_indent = 4 if runtime_enabled_function else 0 %}
{% filter indent(runtime_enabled_indent, true) %}
defaultSignature = V8DOMConfiguration::installDOMClassTemplate(functionTemplate, "{{interface_name}}", {{parent_template}}, {{v8_class}}::internalFieldCount,
- {# Test needed as size 0 constant arrays are not allowed in VC++ #}
+ {# Test needed as size 0 arrays definitions are not allowed per standard
+ (so objects have distinct addresses), which is enforced by MSVC.
+ 8.5.1 Aggregates [dcl.init.aggr]
+ An array of unknown size initialized with a brace-enclosed
+ initializer-list containing n initializer-clauses, where n shall be
+ greater than zero, is defined as having n elements (8.3.4). #}
{% set attributes_name, attributes_length =
('%sAttributes' % v8_class,
'WTF_ARRAY_LENGTH(%sAttributes)' % v8_class)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698