Issue 331743002: Ignore stack adjustment for ebp-based variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331743002: Ignore stack adjustment for ebp-based variables (Closed)

Created:
6 years, 6 months ago by Jim Stichnoth

Modified:
6 years, 6 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

Ignore stack adjustment for ebp-based variables. The TargetX8632 class maintains a "current stack adjustment" during a push sequence, so that pushing or otherwise accessing stack locations during a function arg push sequence can use the right esp offset. This adjustment should only be used for esp-based frames, but it was being used for ebp-based frames as well, causing the wrong stack-based arguments to be pushed. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3878 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b0e142b

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
	M	src/IceTargetLoweringX8632.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
	A	tests_lit/llvm2ice_tests/ebp_args.ll	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jvoung (off chromium)

LGTM thanks! I guess the lit checks are short enough to fix up when we ...

6 years, 6 months ago (2014-06-12 22:05:28 UTC) #2

Jim Stichnoth

6 years, 6 months ago (2014-06-12 22:29:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rb0e142b (presubmit successful).