gpu: Remove Create/DeleteImage IPC by adding an X11_PIXMAP_BUFFER GpuMemoryBuffer type.

content/common/gpu/gpu_memory_buffer_factory.h

Index: content/common/gpu/gpu_memory_buffer_factory.h
diff --git a/content/common/gpu/gpu_memory_buffer_factory.h b/content/common/gpu/gpu_memory_buffer_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..3e2d8f46fb2f8feea60e4ac9e6ff5cd4c5da9315
--- /dev/null
+++ b/content/common/gpu/gpu_memory_buffer_factory.h
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_GPU_GPU_MEMORY_BUFFER_FACTORY_H_
+#define CONTENT_COMMON_GPU_GPU_MEMORY_BUFFER_FACTORY_H_
+
+#include "ui/gfx/geometry/size.h"
+#include "ui/gfx/gpu_memory_buffer.h"
+
+namespace content {
+
+class GpuMemoryBufferFactory {
+ public:
+  static void Initialize();

[alexst (slow to review), 2014/06/18 22:54:49]

What if we made this static GpuMemoryBufferFactory*
CreateGpuMemoryBufferFactory(), which allows platform specific allocation, and
stored the instance in channel_manager and injected it where necessary.

Then below functions would no longer be static and we can add another method
along the lines of

GpuProcessMemoryBuffer* AcquireMemoryBuffer(int primary_id, int secondary_id)

and have

struct GpuProcessMemoryBuffer {
#ifdef X11
 XID xid;
#endif
#ifdef ANDROID
 SurfaceTexture surface_texture;
#endif
//etc.
}

This should give us an in-process handle and remove globals.

[reveman, 2014/06/19 14:56:12]

Not a fan of the idea of another struct with ifdef-ed fields. It makes sense for
the handle that needs to be used with IPC but there shouldn't be necessary to
use this for an in-process handle.

Maybe we could do something like this:

class GpuMemoryBufferFactory {
 public:
  static scoped_ptr<GpuMemoryBufferFactory> Create();

  virtual bool CreateGpuMemoryBuffer(
      const gfx::GpuMemoryBufferHandle& handle, ...);
  virtual void DestroyGpuMemoryBuffer(
      const gfx::GpuMemoryBufferHandle& handle);

  scoped_refptr<gfx::GLImage> AcquireImage(
      const gfx::GpuMemoryBufferHandle& handle);
}

and kill the GLimage factory in ui/gl.

+  static bool CreateGpuMemoryBuffer(const gfx::GpuMemoryBufferHandle& handle,
+                                    const gfx::Size& size,
+                                    unsigned internalformat,
+                                    unsigned usage);
+  static void DestroyGpuMemoryBuffer(const gfx::GpuMemoryBufferHandle& handle);
+  static bool RequestAccessToGpuMemoryBuffer(
+      const gfx::GpuMemoryBufferHandle& handle,
+      int client_id);
+
+ protected:
+  virtual ~GpuMemoryBufferFactory() {}
+};
+
+}  // namespace content
+
+#endif  // CONTENT_COMMON_GPU_GPU_MEMORY_BUFFER_FACTORY_H_