Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 331633004: Check for NULL after Frame lookup in findFrameByName (Closed)

Created:
6 years, 6 months ago by kenrb
Modified:
6 years, 6 months ago
Reviewers:
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Check for NULL after Frame lookup in findFrameByName This function was crashing if the FrameTree name lookup failed to find a matching frame. TBR=japhet@chromium.org BUG=383845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176058

Patch Set 1 #

Patch Set 2 : Improved the conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-12 17:03:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/331633004/20001
6 years, 6 months ago (2014-06-12 17:03:47 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 21:44:01 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:32:58 UTC) #4
Message was sent while issue was closed.
Change committed as 176058

Powered by Google App Engine
This is Rietveld 408576698