Source/web/WebViewImpl.cpp - Issue 331633004: Check for NULL after Frame lookup in findFrameByName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 331633004: Check for NULL after Frame lookup in findFrameByName (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improved the conditional Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index c60757b86f7d6b1a778b03c8b206ae65457884ed..c7de4f34b14099515ead0d62abf2517409f9ffd2 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2490,7 +2490,7 @@ WebFrame* WebViewImpl::findFrameByName(

relativeToFrame = mainFrame();

Frame* frame = toWebLocalFrameImpl(relativeToFrame)->frame();

frame = frame->tree().find(name);

- if (!frame->isLocalFrame())

+ if (!frame || !frame->isLocalFrame())

return 0;

return WebLocalFrameImpl::fromFrame(toLocalFrame(frame));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »