Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 331573002: Land Recent QUIC Changes. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana, wtc, jar (doing other things), Ian Swett, Robbie Shade
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Fix RttStats windowing so if no recent min rtt window is specified, recent_min_rtt is the same as min_rtt. recent_min_rtt is only used within BBR. Merge internal change: 69034369 https://codereview.chromium.org/337433002/ Close QUIC connection with correct flow control error code, added a test for this, and tidyup of a couple of other tests. Close QUIC connection with correct flow control error code. Merge internal change: 69012148 https://codereview.chromium.org/327393004/ Sync'ing DefaultRandom code with internal code. Merge internal change: 69007888 https://codereview.chromium.org/335553002/ Fix some clang_tidy warnings in quic_connection_test. Merge internal change: 69001838 https://codereview.chromium.org/335543002/ Refactor the Connection and Generator so the Creator is completely encapsulated by the Generator. Merge internal change: 69000832 https://codereview.chromium.org/329933003/ API changes to Write path Session on down for FEC protection. Added |fec_protection| flag to data writes to QuicSession and subclasses, down to QuicConnection and QuicPacketGenerator. This flag is used by the packet generator to turn on FEC protection for the flagged data. Merge internal change: 68993204 https://codereview.chromium.org/335533002/ Wrap all tag printing in TagToString Merge internal change: 68862495 https://codereview.chromium.org/332523005/ QuicStreamSequencer closes the connection on receipt of frames overlapping with buffered data. Merge internal change: 68858381 https://codereview.chromium.org/334603002/ Fixed lint errors: At least two spaces is best between code and comments Merge internal change: 68847097 https://codereview.chromium.org/334583002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276964

Patch Set 1 #

Patch Set 2 : fix compiler error - use push_back to initialize vectors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -408 lines) Patch
M net/quic/congestion_control/rtt_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 1 chunk +20 lines, -2 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +58 lines, -58 lines 0 comments Download
M net/quic/crypto/quic_random.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_config.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M net/quic/quic_connection.h View 4 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_connection.cc View 15 chunks +27 lines, -17 lines 0 comments Download
M net/quic/quic_connection_test.cc View 15 chunks +77 lines, -49 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +3 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator.h View 5 chunks +44 lines, -13 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 14 chunks +75 lines, -33 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 27 chunks +113 lines, -105 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 5 chunks +36 lines, -5 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 4 chunks +45 lines, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 14 chunks +28 lines, -28 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_packet_generator_peer.h View 1 chunk +2 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_packet_generator_peer.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 6 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-12 04:11:10 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-12 22:14:27 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-12 22:42:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/331573002/1
6 years, 6 months ago (2014-06-12 22:47:31 UTC) #4
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-12 23:10:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/331573002/20001
6 years, 6 months ago (2014-06-12 23:11:41 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 07:42:18 UTC) #7
Message was sent while issue was closed.
Change committed as 276964

Powered by Google App Engine
This is Rietveld 408576698