Issue 3315014: Successful partitions are never marked bad by cgptlib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3315014: Successful partitions are never marked bad by cgptlib. (Closed)

Created:
10 years, 3 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Successful partitions are never marked bad by cgptlib. Change-Id: I70e54f59b540e9115bb6bd77ae51f49a1f4ab671 BUG=chromeos-partner:1029 TEST=make && make runtests

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -14 lines)			Patch
M	firmware/lib/cgptlib/cgptlib.c	View	1 chunk	+7 lines, -4 lines	1 comment	Download
M	firmware/version.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/cgptlib_test.c	View	2 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

10 years, 3 months ago (2010-09-07 17:24:52 UTC) #2

One nit. LGTM, though.

http://codereview.chromium.org/3315014/diff/1/2
File firmware/lib/cgptlib/cgptlib.c (right):

http://codereview.chromium.org/3315014/diff/1/2#newcode135
firmware/lib/cgptlib/cgptlib.c:135: CGPT_ATTRIBUTE_SUCCESSFUL_MASK |
You don't need to explicitly clear the Attribute bit, since it's already cleared
or you wouldn't be here.

Expand Messages | Collapse Messages