Successful partitions are never marked bad by cgptlib.

tests/cgptlib_test.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <string.h>
 
 #include "cgptlib.h"
 #include "cgptlib_internal.h"
 #include "cgptlib_test.h"
@@ skipping 1050 matching lines @@
   EXPECT(0 == GetEntryTries(e + KERNEL_A));
   EXPECT(1 == GetEntrySuccessful(e2 + KERNEL_A));
   EXPECT(4 == GetEntryPriority(e2 + KERNEL_A));
   EXPECT(0 == GetEntryTries(e2 + KERNEL_A));
   /* Trying successful kernel changes nothing */
   EXPECT(GPT_SUCCESS == GptUpdateKernelEntry(gpt, GPT_UPDATE_ENTRY_TRY));
   EXPECT(1 == GetEntrySuccessful(e + KERNEL_A));
   EXPECT(4 == GetEntryPriority(e + KERNEL_A));
   EXPECT(0 == GetEntryTries(e + KERNEL_A));
   EXPECT(0 == gpt->modified);
-  /* Marking it bad does, though */
+  /* Marking it bad also does not update it. */
   EXPECT(GPT_SUCCESS == GptUpdateKernelEntry(gpt, GPT_UPDATE_ENTRY_BAD));
-  EXPECT(0 == GetEntrySuccessful(e + KERNEL_A));
-  EXPECT(0 == GetEntryPriority(e + KERNEL_A));
+  EXPECT(1 == GetEntrySuccessful(e + KERNEL_A));
+  EXPECT(4 == GetEntryPriority(e + KERNEL_A));
   EXPECT(0 == GetEntryTries(e + KERNEL_A));
-  /* Which affects both copies of the partition entries */
-  EXPECT(0 == GetEntrySuccessful(e2 + KERNEL_A));
-  EXPECT(0 == GetEntryPriority(e2 + KERNEL_A));
-  EXPECT(0 == GetEntryTries(e2 + KERNEL_A));
-  /* And that's caused the GPT to need updating */
-  EXPECT(0x0F == gpt->modified);
+  EXPECT(0 == gpt->modified);
 
   /* Kernel with tries */
   EXPECT(GPT_SUCCESS == GptNextKernelEntry(gpt, &start, &size));
   EXPECT(KERNEL_B == gpt->current_kernel);
   EXPECT(0 == GetEntrySuccessful(e + KERNEL_B));
   EXPECT(3 == GetEntryPriority(e + KERNEL_B));
   EXPECT(2 == GetEntryTries(e + KERNEL_B));
   /* Marking it bad clears it */
   EXPECT(GPT_SUCCESS == GptUpdateKernelEntry(gpt, GPT_UPDATE_ENTRY_BAD));
   EXPECT(0 == GetEntrySuccessful(e + KERNEL_B));
   EXPECT(0 == GetEntryPriority(e + KERNEL_B));
   EXPECT(0 == GetEntryTries(e + KERNEL_B));
+  /* Which affects both copies of the partition entries */
+  EXPECT(0 == GetEntrySuccessful(e2 + KERNEL_B));
+  EXPECT(0 == GetEntryPriority(e2 + KERNEL_B));
+  EXPECT(0 == GetEntryTries(e2 + KERNEL_B));
+  /* And that's caused the GPT to need updating */
+  EXPECT(0x0F == gpt->modified);
 
   /* Another kernel with tries */
   EXPECT(GPT_SUCCESS == GptNextKernelEntry(gpt, &start, &size));
   EXPECT(KERNEL_X == gpt->current_kernel);
   EXPECT(0 == GetEntrySuccessful(e + KERNEL_X));
   EXPECT(2 == GetEntryPriority(e + KERNEL_X));
   EXPECT(2 == GetEntryTries(e + KERNEL_X));
   /* Trying it uses up a try */
   EXPECT(GPT_SUCCESS == GptUpdateKernelEntry(gpt, GPT_UPDATE_ENTRY_TRY));
   EXPECT(0 == GetEntrySuccessful(e + KERNEL_X));
@@ skipping 141 matching lines @@
     printf(COL_RED "The following %d test cases are failed:\n" COL_STOP,
            error_count);
     for (i = 0; i < sizeof(test_cases)/sizeof(test_cases[0]); ++i) {
       if (test_cases[i].retval)
         printf("  %s()\n", test_cases[i].name);
     }
   }
 
   return (error_count) ? 1 : 0;
 }