Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 331493007: Oilpan: Remove converters between Persistent/Member and PassRefPtr/RefPtr. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, arv+blink, Mads Ager (chromium), abarth-chromium, blink-reviews-bindings_chromium.org, kouhei+heap_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Remove converters between Persistent/Member and PassRefPtr/RefPtr. Also, remove remaining RefPtr<MIDIPort>, the last user of one of the converters. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176063

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M Source/bindings/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Handle.h View 4 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-12 21:37:16 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-12 23:22:54 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-12 23:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/331493007/20001
6 years, 6 months ago (2014-06-12 23:41:48 UTC) #4
commit-bot: I haz the power
Change committed as 176063
6 years, 6 months ago (2014-06-12 23:45:25 UTC) #5
Mads Ager (chromium)
6 years, 6 months ago (2014-06-13 06:20:44 UTC) #6
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698