Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/platform/heap/Handle.h

Issue 331493007: Oilpan: Remove converters between Persistent/Member and PassRefPtr/RefPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIConnectionEvent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Handle.h
diff --git a/Source/platform/heap/Handle.h b/Source/platform/heap/Handle.h
index 86af2db03175a29615832dbe1295ec99c737a5c6..6de5dbc17563d21e82f0fec9aadefca5d49d8e44 100644
--- a/Source/platform/heap/Handle.h
+++ b/Source/platform/heap/Handle.h
@@ -360,9 +360,6 @@ public:
operator T*() const { return m_raw; }
operator RawPtr<T>() const { return m_raw; }
- // FIXME: Oilpan: Remove this ASAP. Only here to make Node transition easier.
- template<typename U>
- operator PassRefPtr<U>() { return PassRefPtr<U>(m_raw); }
T* operator->() const { return *this; }
@@ -529,14 +526,6 @@ public:
template<typename U>
Member(const Member<U>& other) : m_raw(other) { }
- // FIXME: Oilpan: Get rid of these ASAP; this is only here to make
- // Node hierarchy transition easier.
- template<typename U>
- Member(const PassRefPtr<U>& other) : m_raw(other.get()) { }
-
- template<typename U>
- Member(const RefPtr<U>& other) : m_raw(other.get()) { }
-
T* release()
{
T* result = m_raw;
@@ -600,10 +589,6 @@ public:
void clear() { m_raw = 0; }
- // FIXME: Oilpan: Remove this ASAP. Only here to make Node transition easier.
- template<typename U>
- operator PassRefPtr<U>() { return PassRefPtr<U>(m_raw); }
-
protected:
void verifyTypeIsGarbageCollected() const
{
@@ -751,16 +736,6 @@ template<typename T, typename U> inline bool operator!=(const Persistent<T>& a,
template<typename T, typename U> inline bool operator==(const Persistent<T>& a, const Persistent<U>& b) { return a.get() == b.get(); }
template<typename T, typename U> inline bool operator!=(const Persistent<T>& a, const Persistent<U>& b) { return a.get() != b.get(); }
-// FIXME: Oilpan: Get rid of these ASAP; only here to make Node transition easier.
-template<typename T, typename U> inline bool operator==(const Member<T>& a, const RefPtr<U>& b) { return a.get() == b.get(); }
-template<typename T, typename U> inline bool operator!=(const Member<T>& a, const RefPtr<U>& b) { return a.get() != b.get(); }
-template<typename T, typename U> inline bool operator==(const RefPtr<T>& a, const Member<U>& b) { return a.get() == b.get(); }
-template<typename T, typename U> inline bool operator!=(const RefPtr<T>& a, const Member<U>& b) { return a.get() != b.get(); }
-template<typename T, typename U> inline bool operator==(const Member<T>& a, const PassRefPtr<U>& b) { return a.get() == b.get(); }
-template<typename T, typename U> inline bool operator!=(const Member<T>& a, const PassRefPtr<U>& b) { return a.get() != b.get(); }
-template<typename T, typename U> inline bool operator==(const PassRefPtr<T>& a, const Member<U>& b) { return a.get() == b.get(); }
-template<typename T, typename U> inline bool operator!=(const PassRefPtr<T>& a, const Member<U>& b) { return a.get() != b.get(); }
-
// CPP-defined type names for the transition period where we want to
// support both reference counting and garbage collection based on a
// compile-time flag.
« no previous file with comments | « Source/modules/webmidi/MIDIConnectionEvent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698