Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 331383006: [Cast] Fix log_deserializer BasePacketEvent merge bug. (Closed)

Created:
6 years, 6 months ago by imcheng
Modified:
6 years, 6 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Cast] Fix log_deserializer BasePacketEvent merge bug. The bug is that if we are merging BasePacketEvent A into B, and A had a valid packet size but B did not (i.e. because it only has receiver events and therefore no packet size) then the merged result would take on the packet size of B which is invalid. The fix is to take the max of the sizes of A and B and set it on the merged result. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M media/cast/logging/log_deserializer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
imcheng
6 years, 6 months ago (2014-06-18 22:53:39 UTC) #1
Alpha Left Google
lgtm
6 years, 6 months ago (2014-06-18 23:35:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/331383006/1
6 years, 6 months ago (2014-06-18 23:37:00 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 09:08:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/164035)
6 years, 6 months ago (2014-06-19 09:08:51 UTC) #5
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 6 months ago (2014-06-19 16:32:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/331383006/1
6 years, 6 months ago (2014-06-19 16:33:57 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 17:59:47 UTC) #8
Message was sent while issue was closed.
Change committed as 278421

Powered by Google App Engine
This is Rietveld 408576698