Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: media/cast/logging/log_deserializer.cc

Issue 331383006: [Cast] Fix log_deserializer BasePacketEvent merge bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/logging/log_deserializer.h" 5 #include "media/cast/logging/log_deserializer.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/big_endian.h" 10 #include "base/big_endian.h"
(...skipping 17 matching lines...) Expand all
28 const int kMaxUncompressedBytes = 60 * 1000 * 1000; 28 const int kMaxUncompressedBytes = 60 * 1000 * 1000;
29 29
30 void MergePacketEvent(const AggregatedPacketEvent& from, 30 void MergePacketEvent(const AggregatedPacketEvent& from,
31 linked_ptr<AggregatedPacketEvent> to) { 31 linked_ptr<AggregatedPacketEvent> to) {
32 for (int i = 0; i < from.base_packet_event_size(); i++) { 32 for (int i = 0; i < from.base_packet_event_size(); i++) {
33 const BasePacketEvent& from_base_event = from.base_packet_event(i); 33 const BasePacketEvent& from_base_event = from.base_packet_event(i);
34 bool merged = false; 34 bool merged = false;
35 for (int j = 0; j < to->base_packet_event_size(); j++) { 35 for (int j = 0; j < to->base_packet_event_size(); j++) {
36 BasePacketEvent* to_base_event = to->mutable_base_packet_event(j); 36 BasePacketEvent* to_base_event = to->mutable_base_packet_event(j);
37 if (from_base_event.packet_id() == to_base_event->packet_id()) { 37 if (from_base_event.packet_id() == to_base_event->packet_id()) {
38 int packet_size = std::max(
39 from_base_event.size(), to_base_event->size());
40 // Need special merge logic here because we need to prevent a valid
41 // packet size (> 0) from being overwritten with an invalid one (= 0).
38 to_base_event->MergeFrom(from_base_event); 42 to_base_event->MergeFrom(from_base_event);
43 to_base_event->set_size(packet_size);
39 merged = true; 44 merged = true;
40 break; 45 break;
41 } 46 }
42 } 47 }
43 if (!merged) { 48 if (!merged) {
44 BasePacketEvent* to_base_event = to->add_base_packet_event(); 49 BasePacketEvent* to_base_event = to->add_base_packet_event();
45 to_base_event->CopyFrom(from_base_event); 50 to_base_event->CopyFrom(from_base_event);
46 } 51 }
47 } 52 }
48 } 53 }
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 } else { 243 } else {
239 return DoDeserializeEvents(data, data_bytes, audio_log, video_log); 244 return DoDeserializeEvents(data, data_bytes, audio_log, video_log);
240 } 245 }
241 } 246 }
242 247
243 DeserializedLog::DeserializedLog() {} 248 DeserializedLog::DeserializedLog() {}
244 DeserializedLog::~DeserializedLog() {} 249 DeserializedLog::~DeserializedLog() {}
245 250
246 } // namespace cast 251 } // namespace cast
247 } // namespace media 252 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698