Make inline blocks correctly update their line box selection state.

Make inline blocks correctly update their line box selection state.

When text is selected, RenderText::setSelectionState marks each RootInlineBox as having selected children.  But if a line contained only an inline-block element, the selection state of that line's RootInlineBox was not updated.

That caused RenderBlockFlow::inlineSelectionGaps to set lastLogicalTop to the wrong value, since it believed the line was not selected.

That caused RenderBlock::selectionGaps to paint a vertical selection gap on top of the affected line, obscuring its content.

This patch adds RenderBlock::setSelectionState, which updates the selection state of the RootInlineBox.

BUG=388324
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176944

[leviw_travelin_and_unemployed, 2014-06-24 18:45:38]

lgtm

[skobes, 2014-06-24 18:51:49]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-24 18:52:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/331373006/20001

[commit-bot: I haz the power, 2014-06-24 20:07:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/12624)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13400)

[skobes, 2014-06-24 20:26:37]

The test "compositing/squashing/selection-repaint-with-gaps.html" is expecting
invalidations that correspond to the incorrect selection painting behavior that
this patch fixes.  I have marked the test as NeedsRebaseline.

[skobes, 2014-06-24 20:26:41]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-24 20:27:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/331373006/40001

[skobes, 2014-06-24 21:33:12]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-24 21:33:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/331373006/60001

[commit-bot: I haz the power, 2014-06-25 04:11:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13467)

[commit-bot: I haz the power, 2014-06-25 05:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 05:11:15]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13467)

[skobes, 2014-06-25 18:45:50]

Changed font in test to work around http://crbug.com/388823.

[skobes, 2014-06-25 18:45:53]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-25 18:46:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/331373006/70001

[commit-bot: I haz the power, 2014-06-25 19:50:37]

Change committed as 176944