Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: Source/core/rendering/RenderBlock.h

Issue 331373006: Make inline blocks correctly update their line box selection state. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 165
166 virtual bool shouldPaintSelectionGaps() const OVERRIDE FINAL; 166 virtual bool shouldPaintSelectionGaps() const OVERRIDE FINAL;
167 GapRects selectionGapRectsForRepaint(const RenderLayerModelObject* repaintCo ntainer); 167 GapRects selectionGapRectsForRepaint(const RenderLayerModelObject* repaintCo ntainer);
168 LayoutRect logicalLeftSelectionGap(RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 168 LayoutRect logicalLeftSelectionGap(RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
169 RenderObject* selObj, LayoutUnit logicalL eft, LayoutUnit logicalTop, LayoutUnit logicalHeight, const PaintInfo*); 169 RenderObject* selObj, LayoutUnit logicalL eft, LayoutUnit logicalTop, LayoutUnit logicalHeight, const PaintInfo*);
170 LayoutRect logicalRightSelectionGap(RenderBlock* rootBlock, const LayoutPoin t& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 170 LayoutRect logicalRightSelectionGap(RenderBlock* rootBlock, const LayoutPoin t& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
171 RenderObject* selObj, LayoutUnit logical Right, LayoutUnit logicalTop, LayoutUnit logicalHeight, const PaintInfo*); 171 RenderObject* selObj, LayoutUnit logical Right, LayoutUnit logicalTop, LayoutUnit logicalHeight, const PaintInfo*);
172 void getSelectionGapInfo(SelectionState, bool& leftGap, bool& rightGap); 172 void getSelectionGapInfo(SelectionState, bool& leftGap, bool& rightGap);
173 RenderBlock* blockBeforeWithinSelectionRoot(LayoutSize& offset) const; 173 RenderBlock* blockBeforeWithinSelectionRoot(LayoutSize& offset) const;
174 174
175 virtual void setSelectionState(SelectionState) OVERRIDE;
176
175 LayoutRect logicalRectToPhysicalRect(const LayoutPoint& physicalPosition, co nst LayoutRect& logicalRect); 177 LayoutRect logicalRectToPhysicalRect(const LayoutPoint& physicalPosition, co nst LayoutRect& logicalRect);
176 178
177 // Helper methods for computing line counts and heights for line counts. 179 // Helper methods for computing line counts and heights for line counts.
178 RootInlineBox* lineAtIndex(int) const; 180 RootInlineBox* lineAtIndex(int) const;
179 int lineCount(const RootInlineBox* = 0, bool* = 0) const; 181 int lineCount(const RootInlineBox* = 0, bool* = 0) const;
180 int heightForLineCount(int); 182 int heightForLineCount(int);
181 void clearTruncation(); 183 void clearTruncation();
182 184
183 void adjustRectForColumns(LayoutRect&) const; 185 void adjustRectForColumns(LayoutRect&) const;
184 virtual LayoutSize columnOffset(const LayoutPoint&) const OVERRIDE; 186 virtual LayoutSize columnOffset(const LayoutPoint&) const OVERRIDE;
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 // FIXME: This is temporary as we move code that accesses block flow 542 // FIXME: This is temporary as we move code that accesses block flow
541 // member variables out of RenderBlock and into RenderBlockFlow. 543 // member variables out of RenderBlock and into RenderBlockFlow.
542 friend class RenderBlockFlow; 544 friend class RenderBlockFlow;
543 }; 545 };
544 546
545 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock()); 547 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
546 548
547 } // namespace WebCore 549 } // namespace WebCore
548 550
549 #endif // RenderBlock_h 551 #endif // RenderBlock_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/text/inline-block-in-selection-root-expected.html ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698