Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 331353003: Use if instead of ifdef SK_SUPPORT_GPU (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@desktop-es
Visibility:
Public.

Description

Use if instead of ifdef SK_SUPPORT_GPU The SK_SUPPORT_GPU is always defined. Committed: https://skia.googlesource.com/skia/+/4509517e03fd245298d4059f4568435d640a1758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Kimmo Kinnunen
Mike, I had to re-upload this issue due to uploading the previous with wrong "base ...
6 years, 6 months ago (2014-06-17 05:01:57 UTC) #1
Kimmo Kinnunen
Brian, would you have time to ok this?
6 years, 4 months ago (2014-07-29 10:52:03 UTC) #2
bsalomon
Yup, thanks, Kimmo. lgtm
6 years, 4 months ago (2014-07-29 12:59:52 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-29 12:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/331353003/1
6 years, 4 months ago (2014-07-29 13:00:47 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 13:12:53 UTC) #6
Message was sent while issue was closed.
Change committed as 4509517e03fd245298d4059f4568435d640a1758

Powered by Google App Engine
This is Rietveld 408576698