Show pid on Observatory VM page

runtime/vm/service.cc

Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index bd24d2a39a71a73e14565a2e76dcc94e8c36e51d..c813d34332284421bfd22bf884f92898eea2503c 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1939,6 +1939,7 @@ static bool HandleVM(JSONStream* js) {
   jsobj.AddProperty("targetCPU", CPU::Id());
   jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());
   jsobj.AddProperty("version", Version::String());
+  jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId());

[koda, 2014/06/16 23:54:46]

Why not use AddProperty(const char* name, intptr_t i)?

Change or add comment to explain.

[Cutch, 2014/06/17 14:49:15]

Sending (possibly) large numbers to JavaScript can be a problem. I prefer to
send integers as strings.

I will add a comment.

   jsobj.AddProperty("assertsEnabled", FLAG_enable_asserts);
   jsobj.AddProperty("typeChecksEnabled", FLAG_enable_type_checks);
   int64_t start_time_micros = Dart::vm_isolate()->start_time();