Show pid on Observatory VM page

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1921 matching lines @@
 };
 
 
 static bool HandleVM(JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", "VM");
   jsobj.AddProperty("id", "vm");
   jsobj.AddProperty("targetCPU", CPU::Id());
   jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());
   jsobj.AddProperty("version", Version::String());
+  jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId());

[koda, 2014/06/16 23:54:46]

Why not use AddProperty(const char* name, intptr_t i)?

Change or add comment to explain.

[Cutch, 2014/06/17 14:49:15]

Sending (possibly) large numbers to JavaScript can be a problem. I prefer to
send integers as strings.

I will add a comment.

   jsobj.AddProperty("assertsEnabled", FLAG_enable_asserts);
   jsobj.AddProperty("typeChecksEnabled", FLAG_enable_type_checks);
   int64_t start_time_micros = Dart::vm_isolate()->start_time();
   int64_t uptime_micros = (OS::GetCurrentTimeMicros() - start_time_micros);
   double seconds = (static_cast<double>(uptime_micros) /
                     static_cast<double>(kMicrosecondsPerSecond));
   jsobj.AddProperty("uptime", seconds);
 
   // Construct the isolate list.
   {
@@ skipping 154 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart