Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/android/navigation_popup.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/notifications/message_center_settings_controller.cc ('K') | « chrome/browser/sync/glue/favicon_cache.cc ('k') | chrome/browser/ui/cocoa/history_menu_bridge.mm » ('j') | components/bookmarks/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/navigation_popup.cc
diff --git a/chrome/browser/ui/android/navigation_popup.cc b/chrome/browser/ui/android/navigation_popup.cc
index 0be85372a23cbacba71949d1ec02429dfc17cb54..0e5a6554221fa9ab9527b5bae1b098845ffa967d 100644
--- a/chrome/browser/ui/android/navigation_popup.cc
+++ b/chrome/browser/ui/android/navigation_popup.cc
@@ -19,7 +19,6 @@
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/android/java_bitmap.h"
-#include "ui/gfx/favicon_size.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
@@ -49,8 +48,7 @@ void NavigationPopup::FetchFaviconForUrl(JNIEnv* env,
// TODO(tedchoc): Request higher favicons based on screen density instead of
// hardcoding kFaviconSize.
favicon_service->GetFaviconImageForPageURL(
- FaviconService::FaviconForPageURLParams(
- url, favicon_base::FAVICON, gfx::kFaviconSize),
+ url,
base::Bind(&NavigationPopup::OnFaviconDataAvailable,
base::Unretained(this),
url),
« chrome/browser/notifications/message_center_settings_controller.cc ('K') | « chrome/browser/sync/glue/favicon_cache.cc ('k') | chrome/browser/ui/cocoa/history_menu_bridge.mm » ('j') | components/bookmarks/browser/bookmark_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698