Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: chrome/browser/notifications/message_center_settings_controller.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_settings_controller.cc
diff --git a/chrome/browser/notifications/message_center_settings_controller.cc b/chrome/browser/notifications/message_center_settings_controller.cc
index 69e9ca9a6a39969b1e1c1b12b9e8f40656992793..1278631549abd3b352e4b876e1450e06b3474bc9 100644
--- a/chrome/browser/notifications/message_center_settings_controller.cc
+++ b/chrome/browser/notifications/message_center_settings_controller.cc
@@ -271,15 +271,11 @@ void MessageCenterSettingsController::GetNotifierList(
name,
notification_service->IsNotifierEnabled(notifier_id)));
patterns_[name] = iter->primary_pattern;
- FaviconService::FaviconForPageURLParams favicon_params(
- url,
- favicon_base::FAVICON | favicon_base::TOUCH_ICON,
sky 2014/07/10 00:03:39 Don't you lose the TOUCH_ICON with this change?
pkotwicz 2014/07/11 01:23:08 TOUCH_ICON is android and IOS only and based on bu
- message_center::kSettingsIconSize);
// Note that favicon service obtains the favicon from history. This means
// that it will fail to obtain the image if there are no history data for
// that URL.
favicon_service->GetFaviconImageForPageURL(
- favicon_params,
+ url,
base::Bind(&MessageCenterSettingsController::OnFaviconLoaded,
base::Unretained(this),
url),

Powered by Google App Engine
This is Rietveld 408576698