chrome/browser/android/favicon_helper.h - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/favicon_helper.h

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/favicon_helper.h

diff --git a/chrome/browser/android/favicon_helper.h b/chrome/browser/android/favicon_helper.h

index 377eaa58cccf2b39c09d9787924d26101b03e81f..e4afb01148b92139f16cc75e40493751125181b3 100644

--- a/chrome/browser/android/favicon_helper.h

+++ b/chrome/browser/android/favicon_helper.h

@@ -20,7 +20,7 @@ class FaviconHelper {

jobject j_profile,

jstring j_page_url,

jint j_icon_types,

- jint j_desired_size_in_dip,

+ jint j_desired_size_in_pixel,

jobject j_favicon_image_callback);

void GetLargestRawFaviconForUrl(JNIEnv* env,

jobject obj,