[Refactor] Change FaviconService API to take in a desired pixel size

chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
index d04a290a1597b429d75d97be03f981a64fb09f38..f347ea23f6f86e938d15f963520d5caeebae1808 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
@@ -69,7 +69,7 @@ public class FaviconHelper {
      * @param profile               Profile used for the FaviconService construction.
      * @param pageUrl               The target Page URL to get the favicon.
      * @param iconTypes             One of the IconType class values.
-     * @param desiredSizeInDip      The size of the favicon in dip we want to get.
+     * @param desiredSizeInPixel    The size of the favicon in pixel we want to get.
      * @param faviconImageCallback  A method to be called back when the result is available.
      *                              Note that this callback is not called if this method returns
      *                              false.
@@ -77,10 +77,10 @@ public class FaviconHelper {
      */
     public boolean getLocalFaviconImageForURL(
             Profile profile, String pageUrl, int iconTypes,
-            int desiredSizeInDip, FaviconImageCallback faviconImageCallback) {
+            int desiredSizeInPixel, FaviconImageCallback faviconImageCallback) {

[sky, 2014/07/10 00:03:39]

Were all call sites already passing in pixels?

         assert mNativeFaviconHelper != 0;
         return nativeGetLocalFaviconImageForURL(mNativeFaviconHelper, profile, pageUrl, iconTypes,
-                desiredSizeInDip, faviconImageCallback);
+                desiredSizeInPixel, faviconImageCallback);
     }
 
     /**