chrome/browser/ui/android/navigation_popup.cc - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/navigation_popup.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/navigation_popup.cc

diff --git a/chrome/browser/ui/android/navigation_popup.cc b/chrome/browser/ui/android/navigation_popup.cc

index 0be85372a23cbacba71949d1ec02429dfc17cb54..0e5a6554221fa9ab9527b5bae1b098845ffa967d 100644

--- a/chrome/browser/ui/android/navigation_popup.cc

+++ b/chrome/browser/ui/android/navigation_popup.cc

@@ -19,7 +19,6 @@

#include "third_party/skia/include/core/SkBitmap.h"

#include "ui/base/resource/resource_bundle.h"

#include "ui/gfx/android/java_bitmap.h"

-#include "ui/gfx/favicon_size.h"

#include "ui/gfx/image/image.h"

#include "url/gurl.h"

@@ -49,8 +48,7 @@ void NavigationPopup::FetchFaviconForUrl(JNIEnv* env,

// TODO(tedchoc): Request higher favicons based on screen density instead of

// hardcoding kFaviconSize.

favicon_service->GetFaviconImageForPageURL(

- FaviconService::FaviconForPageURLParams(

- url, favicon_base::FAVICON, gfx::kFaviconSize),

+ url,

base::Bind(&NavigationPopup::OnFaviconDataAvailable,

base::Unretained(this),

url),